chenjian2664 commented on code in PR #18338:
URL: https://github.com/apache/iceberg/pull/18338#discussion_r4155412827
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -405,6 +409,14 @@ private InclusiveMetricsEvaluator metricsEvaluator() {
return lazyMetricsEvaluator;
}
+ // an equality delete's match condition depends only on its equality fields;
stats for any
+ // other column it carries are irrelevant to that match, so pruning on them
is unsound
+ private static boolean skipMetricsEvaluation(
Review Comment:
Could you try evaluating the filter against the equality fields' stats only,
instead of skipping? InclusiveMetricsEvaluator treats missing stats as "might
match", so predicates on other columns can't
prune, while predicates on the key columns still do:
```
private F withFilterableStats(F contentFile) {
if (contentFile.content() == FileContent.EQUALITY_DELETES) {
return
contentFile.copyWithStats(Set.copyOf(contentFile.equalityFieldIds()));
}
return contentFile;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
