itsbilal commented on PR #2075: URL: https://github.com/apache/iceberg-go/pull/2075#issuecomment-5938661567
@zeroshade I addressed most of your comments and responded to the ones about the expectation with `WithSavedConfig` - I'm open to the approach you suggested, I just think it's harder to understand when the expected use-case for `RefreshTableCredentials` is with externally created tables, and the same assumption about the layering of props is less true outside of `tableWithResponse`. Let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
