bryanck commented on PR #18336: URL: https://github.com/apache/iceberg/pull/18336#issuecomment-5934101766
This PR should address an unresolved concern raised in https://github.com/apache/iceberg/pull/12634 by @rdblue . My thought about the concern is that if a struct without children is passed into the struct prune method, then it is safe to assume this is an empty struct rather than the full struct. This is consistent with `TypeUtil.project()` for example (though different than `TypeUtil.select()`). At the very least we should add a comment similar to the one for `TypeUtil.project()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
