bryanck commented on code in PR #18336:
URL: https://github.com/apache/iceberg/pull/18336#discussion_r4156508002
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestPruneColumns.java:
##########
@@ -305,6 +306,381 @@ public void testVariant() {
assertThat(actual).as("Pruned schema should be
matched").isEqualTo(expected);
}
+ private static MessageType deepNestedFileSchema() {
+ return Types.buildMessage()
+ .addField(
+ Types.primitive(PrimitiveTypeName.INT64,
Type.Repetition.REQUIRED).id(1).named("id"))
+ .addField(
+ Types.buildGroup(Type.Repetition.REQUIRED)
+ .addField(
+ Types.primitive(PrimitiveTypeName.BINARY,
Type.Repetition.REQUIRED)
+ .as(LogicalTypeAnnotation.stringType())
+ .id(3)
+ .named("own"))
+ .addField(
+ Types.buildGroup(Type.Repetition.REQUIRED)
+ .addField(
+ Types.primitive(PrimitiveTypeName.BINARY,
Type.Repetition.REQUIRED)
+ .as(LogicalTypeAnnotation.stringType())
+ .id(5)
+ .named("x"))
+ .addField(
+ Types.buildGroup(Type.Repetition.REQUIRED)
+ .addField(
+ Types.primitive(
+ PrimitiveTypeName.INT64,
Type.Repetition.REQUIRED)
+ .id(7)
+ .named("leaf"))
+ .addField(
+ Types.primitive(
+ PrimitiveTypeName.BINARY,
Type.Repetition.REQUIRED)
+ .as(LogicalTypeAnnotation.stringType())
+ .id(8)
+ .named("big"))
+ .id(6)
+ .named("l3"))
+ .id(4)
+ .named("l2"))
+ .id(2)
+ .named("l1"))
+ .named("table");
+ }
+
+ @Test
+ public void testDeeplyNestedStructProjection() {
Review Comment:
While guidance is to not prefix tests w/ `test`, I feel it is best to keep
these as-is so they are consistent with existing tests in the class .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
