kamcheungting-db commented on PR #940: URL: https://github.com/apache/iceberg-cpp/pull/940#issuecomment-5907124982
This PR is now the final layer in the serde stack: 1. #974 — move `DataFile` serde into core 2. #975 — Java-compatible `DataFile` JSON 3. #939 — core `FileScanTask` serde 4. **#940 — strict schema and partition ID parsing** For the incremental diff that belongs only to this PR, use: https://github.com/kamcheungting-db/iceberg-cpp/compare/filescan-task-serde...strict-schema-spec-json-ids In short, an ID like `10` remains valid, while `1.5`, `true`, and values outside `int32_t` are rejected. Missing v1 partition field IDs remain supported. This PR contains the earlier stack commits because all Apache PRs target `main`; it should be reviewed last. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
