amogh-jahagirdar commented on code in PR #17960:
URL: https://github.com/apache/iceberg/pull/17960#discussion_r4139269287
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -338,6 +346,24 @@ private static Map<String, MetricsMode>
configuredColumnModes(Map<String, String
return builder.build();
}
+ private static Map<String, MetricsMode> partitionColumnModes(PartitionSpec
spec, Schema schema) {
+ if (spec == null || schema == null) {
+ return ImmutableMap.of();
Review Comment:
Yeah that's true. The only path for passing the spec is the for table API ,
meaninig schema also cannot be null. I've tightened this up so that we just use
spec.schema() and also this simplifies the field resolution by using the bound
spec schema as a source of truth. And we know it has to be bound because the
only path is through the api that passes in the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
