rdblue commented on code in PR #18108:
URL: https://github.com/apache/iceberg/pull/18108#discussion_r4138493170
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -468,8 +472,10 @@ private Schema readSchema(boolean includePartition) {
ImmutableMap.of(TrackedFile.TRACKING.fieldId(),
TrackingStruct.BASE_TYPE));
if (requestedProjection != null) {
+ boolean projectsPartition =
+ includePartition ||
requestedProjection.findField(TrackedFile.PARTITION_ID) != null;
Review Comment:
Is this to ensure that all partition fields are projected if one field is
projected? I'm trying to understand the need for this change.
If the requested projection already includes the partition, then why should
it be restored?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
