rdblue commented on code in PR #18108: URL: https://github.com/apache/iceberg/pull/18108#discussion_r4138455551
########## core/src/main/java/org/apache/iceberg/V4ManifestReader.java: ########## @@ -72,7 +70,8 @@ static Builder uncommitted( private final Schema readSchema; private final String tableLocation; private final InclusiveStatsEvaluator statsFilter; - private final Map<Integer, Pair<Evaluator, StructProjection>> partitionFilters; // by spec ID + private final Map<Integer, Evaluator> partitionFilters; // by spec ID + private final Map<Integer, PartitionSpec> specsById; Review Comment: I think this should still track `StructProjection` and should set the projection on the `TrackedFileStruct`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
