amogh-jahagirdar commented on code in PR #17960:
URL: https://github.com/apache/iceberg/pull/17960#discussion_r4135092051
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestWriteMetricsConfig.java:
##########
@@ -282,13 +283,15 @@ public void testCustomMetricCollectionForNestedParquet() {
Map<Integer, Long> nullValueCounts = file.nullValueCounts();
assertThat(nullValueCounts)
- .hasSize(3)
- .containsKeys(longCol.fieldId(), recordId.fieldId(),
recordData.fieldId());
+ .hasSize(4)
Review Comment:
Ah okay it's just the test itself. we're producing multiple files, one of
which is a complete null partitioned file. For that file lower/upper is never
going to be produced.
but the test will still fail (due to task planning not being deterministic)
for the other file.
Taking a step back, this test shouldn't care about partitioning (it's just
testing nested field metrics). So we can just use an unpartitioned spec here.
I think it's another example for why this test class probably isn't super
useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
