mxm commented on code in PR #18302:
URL: https://github.com/apache/iceberg/pull/18302#discussion_r4131495038
##########
.github/workflows/java-ci.yml:
##########
@@ -95,7 +91,10 @@ jobs:
# Read-only: java-ci's build-checks (17) is the global canonical
writer.
cache-read-only: true
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- - run: ./gradlew check -DsparkVersions= -DflinkVersions= -DkafkaVersions=
-Pquick=true -x javadoc -x spotlessCheck
+ - if: ${{ matrix.jvm != 21 || github.event_name != 'pull_request' }}
+ run: ./gradlew check -DsparkVersions= -DflinkVersions= -DkafkaVersions=
-Pquick=true -x javadoc -x spotlessCheck
+ - if: ${{ matrix.jvm == 21 && github.event_name == 'pull_request' }}
+ run: ./gradlew :iceberg-core:check -Pquick=true -x javadoc -x
spotlessCheck
Review Comment:
Why do we only run `:iceberg-core:check` on pull requests? This isn't the
only module which could have JDK 21 related issues.
##########
.github/workflows/java-ci.yml:
##########
@@ -76,10 +76,6 @@ jobs:
matrix:
jvm: [17, 21]
event_name: ['${{ github.event_name }}']
- exclude:
- # Pull requests run the baseline JDK only.
- - event_name: pull_request
- jvm: 21
Review Comment:
Although it would have caught the issue early on, I'm not sure the costs are
worth it running the entire test suite on JDK 17 and 21 prior merging. This may
warrant a separate discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
