manuzhang commented on code in PR #18269:
URL: https://github.com/apache/iceberg/pull/18269#discussion_r4129515454
##########
core/src/test/java/org/apache/iceberg/TestStatsUtil.java:
##########
@@ -541,7 +541,7 @@ public void testContentStatsWriteSchemaNestedStruct() {
Map<String, String> properties =
ImmutableMap.of(TableProperties.METRICS_MODE_COLUMN_CONF_PREFIX +
"id", "none");
Types.StructType actual =
- StatsUtil.statsWriteSchema(schema, MetricsConfig.from(properties,
schema, null));
+ StatsUtil.statsWriteSchema(schema, MetricsTestUtil.from(properties,
schema));
Review Comment:
The iteration order of the fields map is changed after refactoring and
excluding parent field (4 entries -> 3 entries) so the result no longer matches
the "expected". I opened https://github.com/apache/iceberg/pull/18302 to sort
it and fix the failed test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
