rdblue commented on code in PR #18269:
URL: https://github.com/apache/iceberg/pull/18269#discussion_r4126905130
##########
spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##########
@@ -151,7 +151,7 @@ public void testMigrateWithInvalidMetricsConfig() throws
IOException {
assertThatThrownBy(
() -> {
- String props = "map('write.metadata.metrics.column.x', 'X')";
+ String props = "map('write.metadata.metrics.column.x',
'counts')";
Review Comment:
The problem with this test was that both the column name and metrics mode
were invalid. An invalid metrics mode is not stored, since it is equal to the
default. To exercise this failure, the mode has to be valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
