rdblue commented on code in PR #17783: URL: https://github.com/apache/iceberg/pull/17783#discussion_r4127740342
########## format/spec.md: ########## @@ -1352,13 +1353,13 @@ Notes: ### Delete Formats -This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are added by v2 and are not supported in v1. Deletion vectors are added in v3 and are not supported in v2 or earlier. Position delete files must not be added to v3 tables, but existing position delete files are valid. +This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are added by v2 and are not supported in v1. Deletion vectors are added in v3 and are not supported in v2 or earlier. Position delete files must not be added to v3 tables, but existing position delete files are valid. Equality delete files must not be added to v4 tables, but existing equality delete files are valid. Review Comment: I would further simplify this rather than continuing to accumulate restrictions here: > This section details how to encode row-level deletes in Iceberg delete files. > > Row level deletes have changed across Iceberg versions: > - v4 allows writing only deletion vectors that are co-located with data file metadata > - v3 allows writing deletion vectors and equality delete files in delete manifests > - v2 allows writing position delete and equality delete files > - v1 does not support row level deletes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
