stevenzwu commented on code in PR #17783: URL: https://github.com/apache/iceberg/pull/17783#discussion_r4090643126
########## format/spec.md: ########## @@ -1913,6 +1916,12 @@ Reading v4 metadata: * Relative paths must be resolved against the table location before use (see [Path Resolution](#path-resolution)) * When `location` is omitted, the table location must be provided (see [Table Location Specification](#table-location-specification)) +Row-level delete changes: + +* Equality delete files must not be added to v4 tables and equality deletes cannot be added as an entry to a v4 manifest +* Readers must continue to apply equality deletes for v2 and v3 tables and for equality deletes carried over into upgraded v4 tables +* Upgrading a v2 or v3 table to v4 is metadata-only and does not rewrite data or delete files Review Comment: Currently, it sounds that "upgrade **must not** rewrite data or delete files". while it will be the behavior in the reference implementation. It is still a valid behavior if some engine/platform want to rewrite data and delete files during v4 upgrade. We shouldn't forbid it in the spec. maybe a version like this and merge with the point above, `Upgrading a v2/v3 table to v4 does not require rewrite data or delete files. Readers must continue to apply equality deletes carried over from upgrade.` If we keep the two points separate, I would recommend to have the upgrade behavior defined first before the reader behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
