nssalian opened a new pull request, #2069: URL: https://github.com/apache/iceberg-go/pull/2069
### Rationale for the change `puffin/TestReaderPreservesLZ4ChecksumError` fails on Go 1.27.1 (passes on Go 1.25.9): ``` puffin_test.go:783: Error "puffin: unexpected content after footer JSON" does not contain "invalid frame checksum" ``` In `Reader.readFooter`, three paths return "unexpected content after footer JSON", but only one first checked `compressedFooter.err` (the LZ4 read error, e.g. `invalid frame checksum`). Which path runs depends on how far Go's `encoding/json` decoder reads ahead - which changed between Go versions - so on Go 1.27.1 a real checksum failure was reported as "unexpected content" instead. ### Change Check `compressedFooter.err` at all three return sites, not just one. Valid files are unaffected (the error is `nil`, so trailing content still reports "unexpected content after footer JSON"). ### Test `gofmt`/`go vet` clean; `go test ./puffin/` ok on both go1.25.9 and go1.27.1 (was FAIL on 1.27.1 before this change). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
