mengna-lin commented on code in PR #18210:
URL: https://github.com/apache/iceberg/pull/18210#discussion_r4126268473
##########
aws/src/main/java/org/apache/iceberg/aws/AwsKeyManagementClient.java:
##########
@@ -73,7 +73,7 @@ public ByteBuffer wrapKey(ByteBuffer key, String
wrappingKeyId) {
@Override
public boolean supportsKeyGeneration() {
- return true;
+ return false;
Review Comment:
The reason why I made the default value false is that I want to keep the
behavior consistent after the change. Shall we make this configurable in this
PR or a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
