dramaticlly commented on code in PR #18210:
URL: https://github.com/apache/iceberg/pull/18210#discussion_r4125411355
##########
aws/src/main/java/org/apache/iceberg/aws/AwsKeyManagementClient.java:
##########
@@ -73,7 +73,7 @@ public ByteBuffer wrapKey(ByteBuffer key, String
wrappingKeyId) {
@Override
public boolean supportsKeyGeneration() {
- return true;
+ return false;
Review Comment:
This is changed probably because the encryption manager now use generate key
instead of wrapping key if keyGeneration is supported. Capability wise AWS KMS
does support the key generation, so we just need a graceful way to rollout the
behavior change, maybe a devlist email if we want to bundle this together in
this PR, @ggershinsky what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
