zhang-arvin commented on PR #18105: URL: https://github.com/apache/iceberg/pull/18105#issuecomment-5847106900
Both items from your review are done in db9584225. - **Title** now reads `Spark: Fix flaky TestViews temp function name collision` — the change is confined to the `spark/v*` extension test sources, so `Core:` was wrong. - **CI** was not merely red, it was not running at all: the branch had no common ancestor with `main` (it carried a detached fork history), so GitHub produced zero check runs. The branch is now rebuilt directly on current `main` (`HEAD~1 == 729e650b9`), and the workflow suite is running on the new head (35 checks in progress). While doing that I re-checked the diff against current `main`; the fix itself is unchanged and still applies — `viewName()` still suffixes with `new Random().nextInt(1000000)` there, which is the collision. Verification on the rebuilt branch: - `:iceberg-spark:iceberg-spark-extensions-4.2_2.13:test --tests org.apache.iceberg.spark.extensions.TestViews` -> 291 tests, 0 failures, 0 errors (8 skipped, the usual catalog-parameterized skips) - `spotlessApply` on the 4.2 module: clean, no reformatting beyond the change The 3.5, 4.0, 4.1 and 4.2 sources are all updated with the same three-line change; only the 4.2 test task was run locally, since the four copies are otherwise identical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
