xanderbailey commented on PR #3260: URL: https://github.com/apache/iceberg-rust/pull/3260#issuecomment-5812914344
Just an idea, I don't love that we fail at runtime if the user configures both an as of timestamp and a snapshot id to read. Is there a world where we should have a delegate pattern and a new scan type for this that does the resolution and produces the existing struct with a pinned snapshot? Or... and I appreciate it would be a break but rather than having snapshot or timestamp we have some sort of selector enum? This would be more idiomatic in my opinion and would make the invalid stat unrepresentable at compile time? What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
