xanderbailey commented on code in PR #3263:
URL: https://github.com/apache/iceberg-rust/pull/3263#discussion_r4091052802
##########
crates/iceberg/src/io/storage/config/mod.rs:
##########
@@ -45,6 +45,14 @@ pub use oss::*;
pub use s3::*;
use serde::{Deserialize, Serialize};
+/// Deadline in milliseconds for one IO operation, and for every method call
on a returned
+/// reader, writer, lister or deleter. Honored by every
`iceberg-storage-opendal` backend, where
+/// it defaults to 10000 to match OpenDAL's `TimeoutLayer`.
+///
+/// Each retry attempt is bounded separately, so it is a per-attempt budget,
not a total one.
+/// Control operations such as `stat` and `rename` are bounded by a separate,
fixed budget.
+pub const CLIENT_IO_TIMEOUT_MS: &str = "client.io-timeout-ms";
Review Comment:
Given these are going to open dal specific configs, I wonder if we should
namespace them as ‘opendal.’? And define them in the same place as the config
itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
