xanderbailey commented on code in PR #3263:
URL: https://github.com/apache/iceberg-rust/pull/3263#discussion_r4075965831
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -163,35 +164,42 @@ where
impl StorageFactory for OpenDalStorageFactory {
#[allow(unused_variables)]
fn build(&self, config: &StorageConfig) -> Result<Arc<dyn Storage>> {
+ let io_timeout_ms = io_timeout_ms_parse(config.props())?;
Review Comment:
Do you think it would be better to have an `OpenDalClientConfig` struct? So
that we could add retry configuration etc here also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
