huaxingao commented on code in PR #17783: URL: https://github.com/apache/iceberg/pull/17783#discussion_r4057678462
########## format/spec.md: ########## @@ -62,6 +62,7 @@ The full set of changes are listed in [Appendix E](#version-3). Version 4 of the Iceberg spec restructures metadata for improved performance and new capabilities: * Support for [relative locations](#file-locations-in-metadata) in metadata fields +* Writing new [equality deletes](#equality-delete-files) is no longer allowed Review Comment: I'd keep this bullet as a headline and change Appendix E. v3 says `Writers are not allowed to add new position delete files to v3 tables`, so I'll match that: `Writers must not add equality delete files to v4 tables`. For catalogs, I'd leave it out. v3 doesn't require catalogs to reject new position delete files either, so we'd be matching v3 by not saying anything here. ########## format/spec.md: ########## @@ -1352,13 +1353,13 @@ Notes: ### Delete Formats -This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are added by v2 and are not supported in v1. Deletion vectors are added in v3 and are not supported in v2 or earlier. Position delete files must not be added to v3 tables, but existing position delete files are valid. +This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are added by v2 and are not supported in v1. Deletion vectors are added in v3 and are not supported in v2 or earlier. Position delete files must not be added to v3 tables, but existing position delete files are valid. Equality delete files must not be added to v4 tables, but existing equality delete files are valid. There are different formats for encoding row-level deletes: * Deletion vectors (DVs) identify deleted rows within a single referenced data file by position in a bitmap * Position delete files identify deleted rows by file location and row position (**deprecated** in v3) -* Equality delete files identify deleted rows by the value of one or more columns +* Equality delete files identify deleted rows by the value of one or more columns (**prohibited** in v4) Review Comment: Deprecated means you can still write it, but you should not. Prohibited means you cannot write it at all. In v4 we are not allowing new equality deletes, so prohibited is the correct word. This wording came from https://github.com/apache/iceberg/pull/17783/#discussion_r3844741181. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
