sungwy commented on code in PR #18080:
URL: https://github.com/apache/iceberg/pull/18080#discussion_r4086379292


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1410,12 +1400,35 @@ paths:
       - $ref: '#/components/parameters/prefix'
       - $ref: '#/components/parameters/namespace'
       - $ref: '#/components/parameters/table'
+      - $ref: '#/components/parameters/data-access'
 
     post:
       tags:
         - Catalog API
       summary: Remotely signs requests to object storage
       operationId: signRequest
+      description: >
+        Signs one request to object storage on the client's behalf.
+
+
+        `RemoteSignResult` takes one of two forms. With `remote-signing`, 
`uri` is the
+        requested URI and `headers` carries the signature. With 
`presigned-urls`, `uri`
+        carries the signature and `headers` is empty.

Review Comment:
   Yes, that's what I meant in my comment @danielcweeks - I'm using this as an 
example to support the existing protocol (always forwarding header regardless 
of mode)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to