danielcweeks commented on code in PR #18080:
URL: https://github.com/apache/iceberg/pull/18080#discussion_r4075653613
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1410,12 +1400,35 @@ paths:
- $ref: '#/components/parameters/prefix'
- $ref: '#/components/parameters/namespace'
- $ref: '#/components/parameters/table'
+ - $ref: '#/components/parameters/data-access'
post:
tags:
- Catalog API
summary: Remotely signs requests to object storage
operationId: signRequest
+ description: >
+ Signs one request to object storage on the client's behalf.
+
+
+ `RemoteSignResult` takes one of two forms. With `remote-signing`,
`uri` is the
+ requested URI and `headers` carries the signature. With
`presigned-urls`, `uri`
+ carries the signature and `headers` is empty.
Review Comment:
@sungwy I don't see how this example would affect the protocol. The catalog
service is responsible for generating the appropriate request (including signed
headers). Regardless of whether the request is remote signed or pre-signed,
the expectations should be that the returned headers should be included in the
request and the URI should be used as the path of the request.
Ensuring this is a valid operation is up to the catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
