anoopj commented on code in PR #3259:
URL: https://github.com/apache/iceberg-rust/pull/3259#discussion_r4076666711
##########
crates/iceberg/src/io/object_cache.rs:
##########
@@ -36,7 +36,10 @@ pub(crate) enum CachedItem {
#[derive(Clone, Debug, Hash, Eq, PartialEq)]
pub(crate) enum CachedObjectKey {
- ManifestList((String, FormatVersion)),
+ // Location alone: the file is immutable and uniquely identified by its
+ // path, and a cache is bound to one table, so the format version can't
+ // disambiguate two lookups at the same location.
+ ManifestList(String),
Review Comment:
You're right that `parse_with_version` branches on the version and the cache
can outlive a with_metadata upgrade, so "can't disambiguate" was probably not
the best choice. Reworded to the actual invariant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
