anoopj opened a new pull request, #3259: URL: https://github.com/apache/iceberg-rust/pull/3259
## What changes are included in this PR? Follow-up to the review thread on #3235: https://github.com/apache/iceberg-rust/pull/3235#discussion_r4024075908 The manifest-list cache key now uses the location alone; format_version is no longer part of it. `ManifestList::parse_with_version(bytes, version)` is a pure function of its inputs, the bytes are immutable and uniquely identified by their location, and an `ObjectCache` is bound to a single table. So `format_version` can never disambiguate two lookups at the same location. The only case where it could differ for one cache is an in-place format upgrade (v1 -> v2 mid-cache-lifetime). Dropping it is more correct there: the cache serves the original correct v1 parse instead of a miss that would reparse the v1 bytes under v2. ## Are these changes tested? Adds test_get_manifest_list_ignores_format_version, asserting two lookups at one location under different format versions return the same cached Arc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
