rdblue commented on code in PR #18171:
URL: https://github.com/apache/iceberg/pull/18171#discussion_r4075275755
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -116,34 +116,20 @@ private TrackingStruct(TrackingStruct toCopy) {
this.replacedPositions = replacedPositions;
}
- void inheritFrom(Tracking manifestTracking) {
- if (manifestTracking != null) {
- if (snapshotId == null) {
- this.snapshotId = manifestTracking.snapshotId();
- }
-
- // manifests do not distinguish between data and file sequence numbers
Review Comment:
The original version relies on a v4 `Tracking` for the manifest that is
being read, but the reader actually has a `ManifestFile` instance because we
want to keep the union type (`TrackedFile`) limited in the codebase. Things
shouldn't accept `TrackedFile` and validate it when they can take the more
specific interface instead.
Using `ManifestFile` means that we only have one sequence number, so we
can't check here.
In addition, the inheritance implementation isn't really the right place to
check metadata consistency, if we want to check this at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
