YuangGao commented on code in PR #3179:
URL: https://github.com/apache/iceberg-rust/pull/3179#discussion_r4044248003
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -543,7 +567,7 @@ impl Storage for OpenDalStorage {
async fn write(&self, path: &str, bs: Bytes) -> Result<()> {
let (op, relative_path) = self.create_operator(&path)?;
- op.write(relative_path, bs)
+ op.write_options(relative_path, bs, self.write_options())
Review Comment:
Checked the source: `write_options()` and `writer_options()` build the same
`WriteContext` and `Writer` — the one-shot version just does `write` + `close`,
and the chunking happens in `Writer`::`write`, so `write`() does split. The
regression doesn't happen either: `MultipartWriter` initiates lazily, so
anything below the part size ends in `write_once`, a single PutObject.
also added `test_file_io_s3_write_splits_buffer_into_bounded_parts` and
`test_file_io_s3_write_below_part_size_stays_single_request` against MinIO to
pin both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
