CTTY commented on code in PR #3179:
URL: https://github.com/apache/iceberg-rust/pull/3179#discussion_r4031006099
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -175,6 +176,7 @@ impl StorageFactory for OpenDalStorageFactory {
customized_credential_load,
} => Ok(Arc::new(OpenDalStorage::S3 {
config: s3_config_parse(config.props().clone())?.into(),
+ multipart_part_size:
s3_multipart_part_size_parse(config.props())?,
Review Comment:
I think this is wrong. we don't need an extra field in the Storage, the
config should be threaded via `S3Config` directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
