dannycjones commented on code in PR #2933: URL: https://github.com/apache/iceberg-rust/pull/2933#discussion_r4041311713
########## crates/iceberg/src/spec/values/datum.rs: ########## Review Comment: I think we probably ought to explicitly implement arms on things like `impl PartialOrd for Datum` to return `None` for geospatial types, to prevent any mistakes in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
