paleolimbot commented on code in PR #2933: URL: https://github.com/apache/iceberg-rust/pull/2933#discussion_r4040259602
########## crates/iceberg/src/spec/datatypes.rs: ########## @@ -43,6 +43,8 @@ pub const MAP_VALUE_FIELD_NAME: &str = "value"; pub(crate) const MAX_DECIMAL_BYTES: u32 = 24; pub(crate) const MAX_DECIMAL_PRECISION: u32 = 38; +const DEFAULT_GEOSPATIAL_CRS: &str = "OGC:CRS84"; +const EQUIVALENT_DEFAULT_GEOSPATIAL_CRS: &str = "EPSG:4326"; Review Comment: Sounds good. It could also be only canonicalized specifically when converting from GeoArrow to Iceberg (i.e., totally fine to create an Iceberg type with any CRS payload, but GeoArrow types get canonicalization at the edge). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
