amogh-jahagirdar commented on code in PR #18138:
URL: https://github.com/apache/iceberg/pull/18138#discussion_r4030313390
##########
core/src/main/java/org/apache/iceberg/ManifestInfo.java:
##########
@@ -56,12 +55,6 @@ interface ManifestInfo {
Types.NestedField DV =
Types.NestedField.optional(
522, "dv", Types.BinaryType.get(), "Deletion vector for manifest
entries");
- Types.NestedField DV_CARDINALITY =
Review Comment:
I think I agree with that argument. Actually performing the rewrite requires
reading the bitmap anyways, so why do a 2 pass over the root where the first
one has a selective projection; doesn't really buy us much unless checking for
rewrites happens way more frequently, but I don't think that matters much
either. I'll update the spec PR in that case. Thanks @rdblue !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
