rdblue commented on code in PR #18138:
URL: https://github.com/apache/iceberg/pull/18138#discussion_r4030293551
##########
core/src/test/java/org/apache/iceberg/TestManifestInfoStruct.java:
##########
@@ -574,7 +538,7 @@ void kryoSerializationRoundTrip() throws IOException {
assertThat(deserialized.deletedRowsCount()).isEqualTo(300L);
assertThat(deserialized.replacedRowsCount()).isEqualTo(200L);
assertThat(deserialized.minSequenceNumber()).isEqualTo(5L);
- assertThat(deserialized.dv()).isEqualTo(ByteBuffer.wrap(new byte[] {0xF}));
- assertThat(deserialized.dvCardinality()).isEqualTo(1L);
+ assertThat(deserialized.manifestDeletionVector().buffer())
+ .isEqualTo(MumblingBitmapTestUtil.emptyBitmap().buffer());
Review Comment:
Shouldn't this validate using the bytes rather than going through
`emptyBitmap`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
