smaheshwar-pltr commented on code in PR #17984:
URL: https://github.com/apache/iceberg/pull/17984#discussion_r4028411735
##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -212,6 +229,9 @@ private ByteBuffer newKey() {
return ByteBuffer.wrap(newKey);
}
+ /** Encrypted key metadata and its wrapping key. */
+ public record FileEncryptionKeys(EncryptedKey keyEncryptionKey, EncryptedKey
fileKey) {}
Review Comment:
Ah thanks for pointing this out, I did notice this - you're right that this
is the first public-API record type. I agree that though I don't see a concrete
problem here, it's easier to follow convention for now to unblock release, and
potentially revisit this topic later.
In
https://github.com/apache/iceberg/pull/17984/commits/1e0a81a5e66a22e6ddf7f9c1ba8847c3c120a02e,
I've changed this to be a class which IMO is a bit nicer than a pair given
both fields have the same type (consumers of the pair can get them the wrong
way around without realising, named accessors mitigate that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
