amogh-jahagirdar commented on code in PR #17984:
URL: https://github.com/apache/iceberg/pull/17984#discussion_r4028244199
##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -212,6 +229,9 @@ private ByteBuffer newKey() {
return ByteBuffer.wrap(newKey);
}
+ /** Encrypted key metadata and its wrapping key. */
+ public record FileEncryptionKeys(EncryptedKey keyEncryptionKey, EncryptedKey
fileKey) {}
Review Comment:
I feel like we should just use a Pair here just to be consistent and just
limit any risk associated with publishihng a public record type. I like
`record` but I'm a little hesitant to use it on a public structure that may or
may not change in future changes. Practically, there's no serialization risk
either for this case but my main argument is really just around public API
structures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
