nastra commented on code in PR #18109:
URL: https://github.com/apache/iceberg/pull/18109#discussion_r4027116293
##########
core/src/main/java/org/apache/iceberg/util/LocationUtil.java:
##########
@@ -107,7 +107,8 @@ public static String resolveLocation(String tableLocation,
String location) {
return location;
}
- return tableLocation + PATH_SEPARATOR + location;
+ // call toString to cause a NullPointerException if the string is null
+ return tableLocation.toString() + PATH_SEPARATOR + location;
Review Comment:
I mentioned my concerns around this change in
https://github.com/nastra/iceberg/pull/141/changes#r3987115252 but I don't
think it's a blocker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
