anoopj commented on code in PR #18109:
URL: https://github.com/apache/iceberg/pull/18109#discussion_r4021642156
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -562,13 +773,14 @@ public void
partitionFilterPrunesFilesAndCountsSkips(FileFormat format) throws I
assertThat(metrics.scannedDataManifests().value()).as("one manifest is
scanned").isEqualTo(1L);
}
+ // TODO rdblue: is this test still valid
Review Comment:
I think you replaced it with `validationUnknownFormatVersionFailure`. Also
applies to `manifestDeletionVectorIsUnsupported` and `deleteManifestThrows`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]