u70b3 commented on PR #2752: URL: https://github.com/apache/iceberg-rust/pull/2752#issuecomment-5691036952
Hi @laskoviymishka @kevinjqliu @Fokko — could one of you take a look at this PR when you have a chance? Quick context to make the review easier: - **Scope**: core copy-on-write rewrite primitive of the #2269 write-actions epic only — it plans candidate files through the existing scan path (manifest pruning + delete-file application reused), applies a caller-provided `RecordBatch` rewriter per file, writes replacement data files, and returns removed/added/unchanged `DataFile` lists + stats. It deliberately does **not** commit table metadata; the commit adapters are left to #2185 (OverwriteAction) / #2203 (RowDelta). - **State**: rebased onto current `main`, CI green, and the public API snapshot is additions-only. A scan-path reviewer would be ideal since the main structural touch is a small generic refactor of `TableScan::plan_files` (`plan_data_files` with a build-result closure) plus a `clear_predicate()` helper on `FileScanTask`. It has been waiting on review since July; happy to split it further or address any feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
