u70b3 commented on PR #2752: URL: https://github.com/apache/iceberg-rust/pull/2752#issuecomment-5690934149
Rebased onto current `main` (`8193cce`) and addressed the fallout plus review findings: - Adapted to the now-private `FileScanTask` fields (#3091 / #12575c7): the planner clears the row predicate through a new `pub(crate) clear_predicate()`, and reads go through the public accessors — the branch compiles against latest `main` again (the previous push predated that change and every CI job was red on compile). - Wired `table.encryption_manager()` into the replacement writer so an encrypted table is not silently rewritten in plaintext, and added a `FeatureUnsupported` guard for `write.format.default != parquet` (mirrors the datafusion insert path). - Added an end-to-end test on an identity-partitioned table asserting partition values, spec id, and directory (including the null partition) are preserved across rewrite. - Updated the PR description: closed references (#2678, #2590, #2414, #2532) are now marked as closed, and a couple of wording fixes (`docs` → `rustdoc`, `sets` → `lists`). Verified locally: `cargo fmt --all -- --check`, clippy (`-D warnings`), `cargo test -p iceberg cow_rewrite` (18), `scan` (76), `writer` (89), `--doc cow_rewrite`, and the `public-api.txt` diff all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
