blackmwk commented on code in PR #2773:
URL: https://github.com/apache/iceberg-rust/pull/2773#discussion_r4014413667
##########
crates/iceberg/src/spec/partition.rs:
##########
@@ -103,8 +103,53 @@ impl PartitionSpec {
}
/// Returns the partition type of this partition spec.
+ /// If a source column is absent, preserves fixed transform result types
and uses
+ /// unknown for result types that depend on the source type.
pub fn partition_type(&self, schema: &Schema) -> Result<StructType> {
- PartitionSpecBuilder::partition_type(&self.fields, schema)
+ self.partition_type_with_schema_history(schema, &[])
+ }
+
+ /// Resolves dropped sources from the newest retained schema containing
their field ID.
+ /// Sources present in the supplied schema always take precedence over
historical types.
+ pub(crate) fn partition_type_with_schema_history(
Review Comment:
No, we should not allow this additaional behavior, you should follow java
implementation's semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
