blackmwk commented on code in PR #2773:
URL: https://github.com/apache/iceberg-rust/pull/2773#discussion_r4003344401
##########
crates/iceberg/src/scan/task.rs:
##########
@@ -253,7 +253,16 @@ impl FileScanTask {
))
}
(Some(_), Some(partition_spec)) => {
- partition_spec.partition_type(&self.schema)?;
+ // A historical partition spec may reference source columns
that were later
+ // dropped from the current schema. This is valid in v2+
tables, so only
+ // validate transforms whose source columns are still present.
+ for partition_field in partition_spec.fields() {
Review Comment:
No, we should not do it here, we should do it in the method
`PartitionSpec::partition_type`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
