rambleraptor opened a new pull request, #3965:
URL: https://github.com/apache/iceberg-python/pull/3965
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change'
`ty` exposes out 3,547 type errors. This gets us down to 655 type errors.
These errors all stem from the fact that mypy is ignoring errors relating to
optional dependencies.
These come from two different situations:
1. We need `__init__` methods on Pydantic subclasses. This ends up being an
issue on expressions mostly. I found a GitHub issue on
[Pydantic](https://github.com/pydantic/pydantic/discussions/8371) that talks
about the same issue. The duplicative `__init__` methods are annoying, but I
don't see any way around it.
2. There's a bunch of tests where we have to explicitly pass in client=None.
This actually feels more correct, since client isn't a property. This is only
occurring in tests and it's a semantic difference. I'm happy to differ to the
type checker for this one.
## Are these changes tested?
Run `uv run ty check`.
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
