linhongyu510 commented on PR #3145:
URL: https://github.com/apache/iceberg-rust/pull/3145#issuecomment-5663320455
Rebased onto current `main` and fixed the build break; the branch is now at
`4d7e831a` and 0 commits behind.
**What was failing.** `cargo check --all-targets` did not compile:
```
error[E0308]: mismatched types
--> crates/iceberg/src/scan/mod.rs:2758:17
| expected `FileScanTaskDeleteFile`, found
`Result<FileScanTaskDeleteFile, Error>`
```
That one is mine, not a conflict artifact. This PR makes
`FileScanTaskDeleteFile::builder().build()` return `Result` so deletion-vector
metadata is validated at construction, and I missed this call site. It only
surfaced in CI because the lib *test* target is what fails to compile, which is
why `clippy`, `Tests (default)`, `check_standalone` and all three `build`
matrix jobs went red together off a single error.
The task built there is a complete equality delete, so validation cannot
fail; `.unwrap()` matches how the surrounding tests in that file construct
theirs.
**On the rebase.** `main` added the `_serde` module to `scan/task.rs` in the
same region where this branch adds `is_deletion_vector` / `validate`, so git
flagged a conflict. The two changes are independent — serialization support
versus construction-time validation — and both are kept in full; nothing was
dropped to make the rebase apply.
**Verification** (locally, on the rebased head):
- `cargo check -p iceberg --lib --all-targets` — clean, 0 errors
- `cargo test -p iceberg --lib scan::` — 83 passed, 0 failed
- `cargo clippy -p iceberg --all-targets -- -D warnings` — clean
- `cargo fmt -p iceberg -- --check` — clean
I reproduced the original E0308 locally before fixing it, so the failure and
the fix are both confirmed against the same tree CI builds rather than inferred
from the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
