Hugo-WB opened a new pull request, #16353: URL: https://github.com/apache/iceberg/pull/16353
Fixes the first part of: https://github.com/apache/iceberg/issues/16352 for `ExpireSnapshots` By calling `removeEncryptionKey` when we remove snapshot from metadata. This assumes that snapshot <> encryption key is 1:1. I think this is a valid assumption given a new encryption key is created per manifest list [here](https://github.com/apache/iceberg/blob/bec6793af822cb791fa5975b41b8936631556c46/core/src/main/java/org/apache/iceberg/ManifestListWriter.java#L99)? But keen to get thoughts from others on this invariant, I am relatively unfamiliar with all this. Do people know what the intention here was? Are there cases where key re-use could happen? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
