gaborkaszab commented on code in PR #16353:
URL: https://github.com/apache/iceberg/pull/16353#discussion_r4018695003
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1451,6 +1451,7 @@ private Builder rewriteSnapshotsInternal(Collection<Long>
idsToRemove, boolean s
}
removeStatistics(snapshotId);
removePartitionStatistics(snapshotId);
+ removeEncryptionKey(snapshot.keyId());
Review Comment:
I'm quoting from @rdblue , let me know if I misunderstand: "the keys table
is intended to have one or two keys that are reused, not a key per encrypted
file referenced from the table metadata."
For me this means, that theoretically we can have a 1-many relationship
between keys and manifest lists (or whatever else's key we store in the
encrypted keys list).
The [entire
conversation](https://lists.apache.org/thread/rx0tcnqkq0nzj1phwo64ng79pp51hzf9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
