kevinjqliu opened a new pull request, #3959:
URL: https://github.com/apache/iceberg-python/pull/3959

   <!--
   Thanks for opening a pull request!
   -->
   
   <!-- In the case this PR will resolve an issue, please replace 
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   <!-- Closes #${GITHUB_ISSUE_ID} -->
   
   # Rationale for this change
   
   REST view responses already parse `config`, but `_response_to_view` discards 
it when constructing a `View`. Preserve it as `View.config`, following the 
existing `Table.config` pattern, across create, load, and register operations.
   
   The [REST 
specification](https://github.com/apache/iceberg/blob/fd2c44f5ac309198c809211c345d368bb04b5eef/open-api/rest-catalog-open-api.yaml#L4558-L4585)
 defines this optional string-to-string map as view-specific configuration. 
This change only preserves it; applying per-view authentication is outside this 
PR.
   
   ## Are these changes tested?
   
   Added configuration assertions for REST create/load/register responses and 
coverage for explicit/default `View.config`, unchanged properties, and 
unchanged equality. All 39 focused view tests and applicable pre-commit checks, 
including mypy, pass. The full unit suite is blocked during collection by the 
missing optional `thrift` dependency.
   
   ## Are there any user-facing changes?
   
   `View.config` exposes response configuration separately from persistent 
`View.properties` and defaults to an empty mapping. Existing constructor calls 
and view equality remain unchanged.
   
   <!-- In the case of user-facing changes, please add the changelog label. -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to