kevinjqliu opened a new pull request, #3958: URL: https://github.com/apache/iceberg-python/pull/3958
# Rationale for this change Empty schemas are falsy because `Schema` implements `__len__`, so `if not other` incorrectly rejects them. The existing `isinstance` check is enough. Identifier field IDs are unordered, so compare them as sets. Field order and field details still matter; `schema_id` stays ignored. ## Are these changes tested? Yes, 332 schema tests pass, including regressions for both cases. ## Are there any user-facing changes? Empty schemas and schemas with reordered identifier IDs now compare equal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
