qzyu999 commented on code in PR #3813:
URL: https://github.com/apache/iceberg-python/pull/3813#discussion_r3975999875
##########
pyiceberg/table/upsert_util.py:
##########
@@ -28,10 +25,19 @@
In,
Or,
)
+from pyiceberg.io.pyarrow import (
+ upsert_get_rows_to_update,
+ upsert_has_duplicate_rows,
+ upsert_unique_keys,
+)
+if TYPE_CHECKING:
+ import pyarrow as pa
Review Comment:
Thanks @Fokko @rambleraptor, done. I've dissolved `upsert_util.py`
completely into `pyarrow.py`:
- Moved `create_match_filter` into `pyarrow.py` as
`upsert_create_match_filter` (alongside the three helpers already there)
- `upsert_util.py` is now a thin deprecation shim, all three public
functions re-export from `pyarrow.py` with `@deprecated(deprecated_in="0.13.0",
removed_in="0.14.0")`, so existing imports keep working but emit a warning
- Updated `__init__.py` to import directly from `pyarrow.py`, and removed
the `TYPE_CHECKING` clause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
