rambleraptor commented on code in PR #3813:
URL: https://github.com/apache/iceberg-python/pull/3813#discussion_r3910408272
##########
pyiceberg/table/upsert_util.py:
##########
@@ -28,10 +25,19 @@
In,
Or,
)
+from pyiceberg.io.pyarrow import (
+ upsert_get_rows_to_update,
+ upsert_has_duplicate_rows,
+ upsert_unique_keys,
+)
+if TYPE_CHECKING:
+ import pyarrow as pa
Review Comment:
That's elegant. I think that's a great way to consolidate everything without
breaking any one.
Bonus, we get to remove the typechecking clause. I really don't like those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
