amogh-jahagirdar commented on code in PR #17320:
URL: https://github.com/apache/iceberg/pull/17320#discussion_r3944352546
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetSchemaUtil.java:
##########
@@ -129,12 +131,94 @@ public static Type fieldType(GroupType group, String
name) {
public static MessageType pruneColumns(MessageType fileSchema, Schema
expectedSchema) {
Review Comment:
I'm not sure this is a valid case, or at least a case we need to concern
ourselves with in my opinion. The parquet read path where a reader function is
not passed in, isn't invoked anywhere within the codebase and all the engines
pass through a reader function. That path never supported default values let
alone this specific handling of a default value case. Though it maybe a good
idea in a separate PR to block reads through that path if there are initial
default values and a reader function isn't specified, but considering it's been
there and hasn't really been a practical issue I'd prefer to leave it for a
separate PR>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
